Fix VideoMAEforPretrained dtype error #27296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It is not possible to train VideoMAEForPreTraining with bfloat16, because the labels are always stored as float32.
This code snippet triggers the error.
Full TraceBack
The problem is that when computing the loss, the labels are in
float32
therefore, the returned loss is also infloat32
.This small change, fixes the issue and allows training VideoMAEForPreTraining model with bfloat16 dtype.
Before submitting
Pull Request section?
to it if that's the case: VideoMAEforPretrained cannot be trained with Bfloat16 #27295
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
@amyerobertsmembers/contributors who may be interested in your PR.